SQL/JSON json_table plan clause

First seen: 2024-12-17 15:11:02+00:00 · Messages: 15 · Participants: 5

Latest Update

2026-05-18 · claude-opus-4-6

Incremental Update: v23 Patch Set Submitted

The author (hukutoc@gmail.com) has submitted v23, addressing most of Alexander Korotkov's 8 review points from the previous round. The key development is the restructuring into a 3-patch series and the addition of documentation.

What Changed in v23

  1. Patch split into 3 parts: The submission is now organized as:

    • v23-0001: Core code changes (main PLAN clause implementation)
    • v23-0002: Test cases and expected output files
    • v23-0003: Documentation (previously missing — this was a noted blocker)

  2. Fixes applied (per author's acknowledgment of Korotkov's 8 points):

    • The IsA() bug on non-Node structures: fixed
    • Behavior default mismatch (EMPTY_ARRAY vs EMPTY): fixed — changed to use default behavior, removing unnecessary ERROR emission
    • Test cases made "much more readable" (likely adopting the suggestion to improve formatting/naming)
    • Multiple other items marked "done"

  3. Still outstanding: The author explicitly notes that pgindent formatting pass is "not done yet but would provide a newer version with it."

  4. Documentation now provided: This resolves one of the previously identified blockers, though no details on the documentation content are visible in this message.

Assessment

This is a substantive progress update — the patch has moved from "missing documentation, multiple known bugs" to "most review items addressed, one remaining TODO (pgindent)." The reorganization into separate patches for code/tests/docs follows standard pgsql-hackers practice for reviewability. The patch is approaching a state where it could receive a more thorough final review pass.